| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Sehrope Sarkuni <sehrope(at)jackdb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, david(at)fetter(dot)org |
| Subject: | Re: Add jsonlog log_destination for JSON server logs |
| Date: | 2022-01-05 07:32:46 |
| Message-ID: | YdVJnqmcxLx/78i6@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 02, 2022 at 01:34:45PM -0800, Andres Freund wrote:
> The tests don't seem to pass on windows:
> https://cirrus-ci.com/task/5412456754315264?logs=test_bin#L47
> https://api.cirrus-ci.com/v1/artifact/task/5412456754315264/tap/src/bin/pg_ctl/tmp_check/log/regress_log_004_logrotate
>
> psql:<stdin>:1: ERROR: division by zero
> could not open "c:/cirrus/src/bin/pg_ctl/tmp_check/t_004_logrotate_primary_data/pgdata/current_logfiles": The system cannot find the file specified at t/004_logrotate.pl line 87.
This seems to point out that the syslogger is too slow to capture the
logrotate signal, and the patch set is introducing nothing new in
terms of infrastructure, just an extra value for log_destination.
This stuff passes here, and I am not spotting something amiss after an
extra close read.
Attached is an updated patch set that increases the test timeout (5min
-> 10min). That should help, I assume.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Some-refactoring-of-elog-specific-routines.patch | text/x-diff | 10.2 KB |
| v8-0002-Refactor-CSV-specific-code-into-its-own-file.patch | text/x-diff | 14.6 KB |
| v8-0003-JSON-logging.patch | text/x-diff | 34.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-01-05 07:53:05 | Re: support for MERGE |
| Previous Message | Dag Lem | 2022-01-05 07:05:45 | Re: daitch_mokotoff module |