| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make pg_waldump report replication origin ID, LSN, and timestamp. |
| Date: | 2021-12-09 07:02:03 |
| Message-ID: | YbGp69aEgPFa9YLE@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 08, 2021 at 05:03:30PM +0900, Masahiko Sawada wrote:
> Agreed. I've attached an updated patch that incorporated your review
> comments. Please review it.
That looks correct to me. One thing that I have noticed while
reviewing is that we don't check XactCompletionApplyFeedback() in
xact_desc_commit(), which would happen if a transaction needs to do
a remote_apply on a standby. synchronous_commit is a user-settable
parameter, so it seems to me that it could be useful for debugging?
That's not related to your patch, but while we are looking at the
area..
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Make-pg_waldump-report-replication-origin-ID-LSN-.patch | text/x-diff | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2021-12-09 07:11:53 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Previous Message | Bharath Rupireddy | 2021-12-09 06:38:46 | Re: Is there a way (except from server logs) to know the kind of on-going/last checkpoint? |