| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make pg_waldump report replication origin ID, LSN, and timestamp. |
| Date: | 2021-12-08 08:03:30 |
| Message-ID: | CAD21AoB+k6F-P4f_Jho0zwZHeNt6hcp0Xzw4-zkGO5opN-mTjA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 8, 2021 at 4:31 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Dec 06, 2021 at 11:24:09PM +0900, Masahiko Sawada wrote:
> > On Mon, Dec 6, 2021 at 5:09 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >> Shouldn't you check for parsed.origin_lsn instead? The replication
> >> origin is stored there as far as I read EndPrepare().
> >
> > Also, looking at PrepareRedoAdd(), we check the replication origin id.
> > So I think that it'd be better to check origin_id for consistency.
>
> Okay, this consistency would make sense, then. Perhaps some comments
> should be added to tell that?
Agreed. I've attached an updated patch that incorporated your review
comments. Please review it.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Make-pg_waldump-report-replication-origin-ID-LSN-.patch | application/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-12-08 08:14:14 | Re: enable certain TAP tests for MSVC builds |
| Previous Message | Kyotaro Horiguchi | 2021-12-08 07:35:15 | Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint? |