Re: Remove extra Logging_collector check before calling SysLogger_Start()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove extra Logging_collector check before calling SysLogger_Start()
Date: 2021-12-05 00:49:45
Message-ID: YawMqX8JjZJ1AEiw@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 03, 2021 at 12:45:34PM -0500, Tom Lane wrote:
> I think it's fine as-is; good belt-and-suspenders-too programming.
> It's not like the extra check inside SysLogger_Start() is costly.

+1.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-12-05 00:53:15 Re: Do sys logger and stats collector need wait events WAIT_EVENT_SYSLOGGER_MAIN/_PGSTAT_MAIN?
Previous Message Michael Paquier 2021-12-05 00:44:16 Re: RecoveryInProgress() has critical side effects