From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
Cc: | Suraj Khamkar <khamkarsuraj(dot)b(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Tab completion for CREATE SCHEMAAUTHORIZATION |
Date: | 2021-12-03 01:19:23 |
Message-ID: | Yalwm1pc6X+GVxWn@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 11, 2021 at 10:16:15AM +0900, Michael Paquier wrote:
> + else if (Matches("CREATE", "SCHEMA", "AUTHORIZATION"))
> + COMPLETE_WITH_QUERY(Query_for_list_of_owner_roles);
> + else if (Matches("CREATE", "SCHEMA", MatchAny, "AUTHORIZATION"))
> + COMPLETE_WITH_QUERY(Query_for_list_of_owner_roles);
> + else if (Matches("CREATE", "SCHEMA", MatchAny, "AUTHORIZATION", MatchAny))
> + COMPLETE_WITH("CREATE", "GRANT");
> + else if (Matches("CREATE", "SCHEMA", MatchAny))
> + COMPLETE_WITH("AUTHORIZATION", "CREATE", "GRANT");
> Looks like you forgot the case "CREATE SCHEMA AUTHORIZATION MatchAny"
> that should be completed by GRANT and CREATE.
This patch has been waiting on author for more than a couple of weeks,
so I have marked it as returned with feedback in the CF app. Please
feel free to resubmit if you are able to work more on that.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2021-12-03 01:28:34 | keepliaves etc. as environment variables |
Previous Message | Michael Paquier | 2021-12-03 01:16:24 | Re: CLUSTER on partitioned index |