Re: Deduplicate code updating ControleFile's DBState.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Deduplicate code updating ControleFile's DBState.
Date: 2021-11-29 04:42:19
Message-ID: YaRaK6AM0ZyuQ2AD@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 29, 2021 at 09:28:23AM +0530, Bharath Rupireddy wrote:
> In that case, why can't we inline UpdateControlFile to avoid the
> function call cost? Do you see any issues with it?

This routine is IMO not something worth bothering about.

> BTW, the v6 patch proposed by Amul at [1], looks good to me.

Yes, I have no problems with this part, so done.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2021-11-29 04:44:52 Re: row filtering for logical replication
Previous Message Amit Kapila 2021-11-29 04:13:41 Re: Non-superuser subscription owners