Re: Deduplicate code updating ControleFile's DBState.

On Sun, Nov 28, 2021 at 07:53:13AM +0530, Bharath Rupireddy wrote:
> Isn't it better if we update the ControlFile->time at the end of the
> update_controlfile, after file write/sync?

I don't quite understand your point here. We want to update the
control file's timestamp when it is written, before calculating its
CRC.

> Why do we even need UpdateControlFile which just calls another
> function? It may be there for usability and readability, but can't the
> pg backend code just call update_controlfile(DataDir, ControlFile,
> true); directly so that a function call cost can be avoided?
> Otherwise, why can't we make UpdateControlFile an inline function? I'm
> not sure if any of the compilers will ever optimize by inlining it
> without the "inline" keyword.

I would leave it as-is as UpdateControlFile() is a public API old
enough to vote (a70e74b0). Anyway, that's a useful wrapper for the
backend.
--
Michael