Clean up build warnings of plperl with clang-12+

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Clean up build warnings of plperl with clang-12+
Date: 2021-11-09 22:35:21
Message-ID: YYr3qYa/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

This is a follow-up of the discussion that happened here:

Recently, we are getting warnings in the build of plperl when using at
least clang-12 because of their new flag -Wcompound-token-split-by-macro,
all the warnings coming from Perl itself.

Upstream has posted a fix about that but it will take time before this
propagates across the buildfarm (five~ animals are now impacted?):

dangomushi is impacted by that, and I'd like to stick an -Werror in it
as it is proving to be good in detecting incorrect placeholders.

Tom has suggested that we could add -Wno-compound-token-split-by-macro
to take care of the issue on our side, and attached is a patch to do

Any objections? I'd like to get this back-patched.


Attachment Content-Type Size
plperl-clang-warnings.patch text/x-diff 2.9 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-11-09 23:08:07 Re: prevent immature WAL streaming
Previous Message Tom Lane 2021-11-09 22:20:41 Frontend error logging style