From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, 近藤雄太 <kondo(at)sraoss(dot)co(dot)jp>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, buildfarm(at)sraoss(dot)co(dot)jp |
Subject: | Re: Missing include <openssl/x509.h> in be-secure-openssl.c? |
Date: | 2021-11-04 07:38:00 |
Message-ID: | YYON2JtkHZfYArY/@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 03, 2021 at 11:45:26PM -0400, Tom Lane wrote:
> Yeah, I noted the comment about WIN32_LEAN_AND_MEAN in the
> stackoverflow thread too ... but as you say, it seems like
> that should make the problem less probable not more so.
> Still, it's hard to think of any other relevant change.
Yeah, I don't see how this could be linked to WIN32_LEAN_AND_MEAN.
> Anyway, my thought now is (1) move the openssl includes to
> after system includes in both *-secure-openssl.c files,
> and (2) add comments explaining why the order is critical.
> But it's late here and I'm not going to mess with it right now.
> If you want to take a shot at a blind fix before hamerkop's
> next run, have at it.
Reading through the error logs that Thomas has posted (thanks!), I
have seen error patterns like that with a dirty build repository. So
it could be possible that hamerkop is reusing a directory where some
code has already been compiled on.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-11-04 07:41:04 | Re: should we enable log_checkpoints out of the box? |
Previous Message | Michael Paquier | 2021-11-04 07:31:48 | Re: Teach pg_receivewal to use lz4 compression |