| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sven Klemm <sven(at)timescale(dot)com> |
| Subject: | Re: [PATCH] Fix memory corruption in pg_shdepend.c |
| Date: | 2021-10-26 05:43:26 |
| Message-ID: | YXeVfoH3Jtm/2CUq@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 25, 2021 at 11:59:52AM -0400, Tom Lane wrote:
> I agree that we're not testing that area well enough. Proposed
> patch seems basically OK, but I think the test needs to be stricter
> about what the expected output looks like --- for instance, it
> wouldn't complain if tab_foobar were described as something other
> than a table.
Indeed. There was also a problem in the regex itself, where '|' was
not escaped so the regex was not strict enough. While on it, I have
added a policy in the set copied to the new database. Testing the
case where the set of slots is full would require 2300~ entries, that
would take some time..
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| createdb-tap-deps-v2.patch | text/x-diff | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-10-26 06:07:01 | Re: jsonb crash |
| Previous Message | Shinya Kato | 2021-10-26 05:09:09 | Re: CREATEROLE and role ownership hierarchies |