| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sven Klemm <sven(at)timescale(dot)com> |
| Subject: | Re: [PATCH] Fix memory corruption in pg_shdepend.c |
| Date: | 2021-10-25 07:51:04 |
| Message-ID: | YXZh6EwFNOyrA0s3@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 21, 2021 at 11:42:31AM +0900, Michael Paquier wrote:
> It is easy enough to get an error on the new database with
> pg_describe_object(). Your part about adding a shared dependency with
> a table on a given role is simple enough, as well. While looking for
> a place where to put such a test, 020_createdb.pl felt like a natural
> place and we don't have any coverage for the case of TEMPLATE with
> createdb. So I would like to suggest something like the attached for
> HEAD.
I was thinking on this one over the last couple of days, and doing a
copy of shared deps from a template within createdb still feels
natural, as of this patch:
https://www.postgresql.org/message-id/YXDTl+PfSnqmbbkE@paquier.xyz
Would somebody object to the addition of this test? Or perhaps
somebody has a better idea?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-10-25 08:10:13 | Re: pg_receivewal starting position |
| Previous Message | Bharath Rupireddy | 2021-10-25 07:50:32 | Re: Improve the HINT message of the ALTER command for postgres_fdw |