| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Vik Fearing <vik(at)postgresfriends(dot)org>, "postgresql(at)zr40(dot)nl" <postgresql(at)zr40(dot)nl>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable |
| Date: | 2021-10-13 03:42:00 |
| Message-ID: | YWZViGJFJkrgBKwk@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Oct 13, 2021 at 12:06:32AM +0000, Bossart, Nathan wrote:
> At first glance, it looks like ALTER INDEX .. ALTER COLUMN ... SET
> uses the wrong validation function. I've attached a patch where I've
> attempted to fix that and added some tests.
The gap is larger than than, because ALTER INDEX .. ALTER COLUMN
.. SET is supported by the parser but we don't document it. The only
thing we document now is SET STATISTICS that applies to a column
*number*.
Anyway, specifying a column name for an ALTER INDEX is not right, no?
Just take for example the case of an expression which has a hardcoded
column name in pg_attribute. So these are not specific to indexes,
which is why we apply column numbers for the statistics case. I think
that we'd better just reject those cases until there is a proper
design done here. As far as I can see, I guess that we should do
things similarly to what we do for SET STATISTICS with column
numbers when it comes to indexes.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2021-10-13 08:19:26 | BUG #17226: hot standby mode, create database and drop database cause standby restrat failed |
| Previous Message | Bossart, Nathan | 2021-10-13 02:20:29 | Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-10-13 04:21:05 | Re: Bug in DefineRange() with multiranges |
| Previous Message | Amit Langote | 2021-10-13 03:41:17 | Re: [BUG] Unexpected action when publishing partition tables |