Re: Proposal: Save user's original authenticated identity for logging

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: Save user's original authenticated identity for logging
Date: 2021-09-22 07:39:10
Message-ID: YUrdnoEc4NPfBZfI@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 22, 2021 at 08:59:38AM +0200, Peter Eisentraut wrote:
> I noticed this patch eliminated one $Test::Builder::Level assignment. Was
> there a reason for this?
>
> I think we should add it back, and also add a few missing ones in similar
> places. See attached patch.
>
> [...]
>
> {
> + local $Test::Builder::Level = $Test::Builder::Level + 1;
> +

So you are referring to this one removed in c50624c. In what does
this addition change things compared to what has been added in
connect_ok() and connect_fails()? I am pretty sure that I have
removed this one because this logic got refactored in
PostgresNode.pm.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-09-22 07:49:10 Re: OpenSSL 3.0.0 compatibility
Previous Message Michael Paquier 2021-09-22 07:27:39 Re: Timeout failure in 019_replslot_limit.pl