Re: Teach pg_receivewal to use lz4 compression

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: gkokolatos(at)pm(dot)me
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Teach pg_receivewal to use lz4 compression
Date: 2021-09-17 07:39:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Sep 16, 2021 at 03:17:15PM +0000, gkokolatos(at)pm(dot)me wrote:
> Hopefully fixed.

Thanks for the new version. I have put my hands on the patch, and
began reviewing its internals with LZ4. I am not done with it yet,
and I have noticed some places that could be improved (error handling,
some uses of LZ4F_flush() that should be replaced LZ4F_compressEnd(),
and more tweaks). I'll send an updated version once I complete my
review, but that looks rather solid overall.

The changes done in close_walfile()@receivelog.c are useful taken
independently, so I have applied these separately.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ronan Dunklau 2021-09-17 08:09:00 Re: Patch to avoid orphaned dependencies
Previous Message Kyotaro Horiguchi 2021-09-17 07:18:30 Re: walsender timeout on logical replication set