Re: BUG #17186: In connect.c, the lock connections_mutex is not correctly released(Line 463) at the return(Line 522)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: ryancaicse(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17186: In connect.c, the lock connections_mutex is not correctly released(Line 463) at the return(Line 522)
Date: 2021-09-10 07:07:26
Message-ID: YTsELsxLaslKcn+m@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Sep 10, 2021 at 04:29:36AM +0000, PG Bug reporting form wrote:
> The problem is that the lock connections_mutex should be released at the end
> of the function. But it not released when conn_keywords == NULL ||
> conn_values == NULL (ecpg_alloc got errors and return NULL).

ecpg_alloc() is just a wrapper to calloc(), so errors are very
unlikely going to happen in this code path. It does not change the
fact that it is wrong. Nice catch, will fix.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2021-09-10 08:57:56 BUG #17187: Incorrect field update operation?
Previous Message PG Bug reporting form 2021-09-10 04:29:36 BUG #17186: In connect.c, the lock connections_mutex is not correctly released(Line 463) at the return(Line 522)