From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Sehrope Sarkuni <sehrope(at)jackdb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, david(at)fetter(dot)org |
Subject: | Re: Add jsonlog log_destination for JSON server logs |
Date: | 2021-09-10 01:07:51 |
Message-ID: | YTqv5ycGhAN72tDc@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Sep 09, 2021 at 11:17:01AM +0900, Michael Paquier wrote:
> I was thinking to track stderr as a case where no bits are set in the
> flags for the area of the destinations, but that's a bit crazy if we
> have a lot of margin in what can be stored. I have looked at that and
> finished with the attached which is an improvement IMO, especially
> when it comes to the header validation.
One part that was a bit flacky after more consideration is that the
header validation would consider as correct the case where both stderr
and csvlog are set in the set of flags. I have finished by just using
pg_popcount() on one byte with a filter on the log destinations,
making the whole more robust. If there are any objections, please let
me know.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
syslogger-flags-2.patch | text/plain | 4.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2021-09-10 01:38:39 | Re: corruption of WAL page header is never reported |
Previous Message | Fujii Masao | 2021-09-10 00:23:45 | Re: Allow escape in application_name |