Re: [PATCH] test/ssl: rework the sslfiles Makefile target

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date: 2021-09-09 01:32:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Sep 08, 2021 at 07:32:03PM +0000, Jacob Champion wrote:
> On Fri, 2021-09-03 at 23:21 +0000, Jacob Champion wrote:
> > > One small-ish comment that I have is about all the .config files we
> > > have at the root of src/test/ssl/, bloating the whole. I think that
> > > it would be a bit cleaner to put all of them in a different
> > > sub-directory, say just config/ or conf/.
> >
> > That sounds reasonable. I won't be able to get to it before the holiday
> > weekend, but I can put up a patch sometime next week.
> Done in v6, a three-patch squashable set. I chose conf/ as the
> directory.

Looks sensible to me. One thing I can see, while poking at it, is
that the README mentions sslfiles to recreate the set of files. But
it is necessary to do sslfiles-clean once, as sslfiles is a no-op if
the set of files exists.

I have not been able to check that this is compatible across all the
versions of OpenSSL we support on HEAD. By looking at the code, that
should be fine but it would be good to be sure.

Daniel, you are registered as a reviewer of this thread
( So I guess that you
would prefer to look at that by yourself and perhaps take care of the

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message 2021-09-09 02:12:08 RE: Parallel Inserts (WAS: [bug?] Missed parallel safety checks..)
Previous Message Melanie Plageman 2021-09-09 01:28:38 Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)