| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Estimating HugePages Requirements? |
| Date: | 2021-09-07 04:00:08 |
| Message-ID: | YTbjyHkTa2xBdzgf@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On Mon, Sep 06, 2021 at 11:55:42PM +0000, Bossart, Nathan wrote:
> Attached is a new patch set. The first two patches just add the new
> GUCs, and the third is an attempt at providing useful values for those
> GUCs via -C.
+ sprintf(buf, "%lu MB", size_mb);
+ SetConfigOption("shared_memory_size", buf, PGC_INTERNAL, PGC_S_OVERRIDE);
One small-ish comment about 0002: there is no need to add the unit
into the buffer set as GUC_UNIT_MB would take care of that. The patch
looks fine.
+#ifndef WIN32
+#include <sys/mman.h>
+#endif
So, this is needed in ipci.c to check for MAP_HUGETLB. I am not much
a fan of moving around platform-specific checks when these have
remained local to each shmem implementation. Could it be cleaner to
add GetHugePageSize() to win32_shmem.c and make it always declared in
the SysV implementation?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-09-07 06:24:21 | Re: Estimating HugePages Requirements? |
| Previous Message | Bossart, Nathan | 2021-09-06 23:55:42 | Re: Estimating HugePages Requirements? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-09-07 04:02:08 | Re: [BUG] Unexpected action when publishing partition tables |
| Previous Message | torikoshia | 2021-09-07 03:41:02 | EXPLAIN(VERBOSE) to CTE with SEARCH BREADTH FIRST fails |