| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jacob Champion <pchampion(at)vmware(dot)com> |
| Cc: | "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Date: | 2021-09-03 00:46:29 |
| Message-ID: | YTFwZcl6NMCmqifQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 02, 2021 at 04:42:14PM +0000, Jacob Champion wrote:
> Done that way in v5. It's a lot of moved code, so I've kept it as two
> commits for review purposes.
Nice. This is neat. The split helps a lot to understand how you've
changed things from the original implementation. As a whole, this
looks rather committable to me.
One small-ish comment that I have is about all the .config files we
have at the root of src/test/ssl/, bloating the whole. I think that
it would be a bit cleaner to put all of them in a different
sub-directory, say just config/ or conf/.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-09-03 01:45:33 | Re: Estimating HugePages Requirements? |
| Previous Message | Tom Lane | 2021-09-03 00:09:16 | Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters |