Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date: 2021-09-13 02:37:38
Message-ID: YT65clO3UOG9isEV@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 12, 2021 at 10:14:36PM -0300, Euler Taveira wrote:
> On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
>> nitpick: It looks like there's an extra set of parentheses around
>> errmsg().
>
> Indeed. Even the requirement for extra parenthesis around auxiliary function
> calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).

Yes. The patch makes sense. I am not seeing any other places that
could be grouped, so that looks fine as-is.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-09-13 03:00:22 Re: brin multi minmax crash for inet value
Previous Message Michael Paquier 2021-09-13 02:22:37 Re: Add jsonlog log_destination for JSON server logs