Re: [PATCH] pgbench: add multiconnect option

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: David Christensen <david(dot)christensen(at)crunchydata(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] pgbench: add multiconnect option
Date: 2021-08-27 06:32:13
Message-ID: YSiG7VlbuZ/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jul 01, 2021 at 12:22:45PM +0200, Fabien COELHO wrote:
> Good. I was thinking of adding such capability, possibly for handling
> connection errors and reconnecting…

round-robin and random make sense. I am wondering how round-robin
would work with -C, though? Would you just reuse the same connection
string as the one chosen at the starting point.

> I was thinking of providing a allowing a list of conninfo strings with
> repeated options, eg --conninfo "foo" --conninfo "bla"…

That was my first thought when reading the subject of this thread:
create a list of connection strings and pass one of them to
doConnect() to grab the properties looked for. That's a bit confusing
though as pgbench does not support directly connection strings, and we
should be careful to keep fallback_application_name intact.

> Your approach using PGSERVICEFILE also make sense!

I am not sure that's actually needed here, as it is possible to pass
down a service name within a connection string. I think that you'd
better leave libpq do all the work related to a service file, if
specified. pgbench does not need to know any of that.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-08-27 06:33:24 Re: Added schema level support for publication.
Previous Message Michael Paquier 2021-08-27 06:19:04 Re: [PATCH] Proof of concept for GUC improvements