Re: Add some tests for pg_stat_statements compatibility verification under contrib

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Erica Zhang <ericazhangy(at)qq(dot)com>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add some tests for pg_stat_statements compatibility verification under contrib
Date: 2021-08-25 07:16:08
Message-ID: YSXuODI9V2oyhQYJ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 15, 2021 at 03:05:24PM +0800, Erica Zhang wrote:
> This way the same query can be reused for both older versions and current
> version.
> Yep, it's neater to use the query as you suggested. Thanks!
>
> Also, can you register your patch for the next commitfest at
> https://commitfest.postgresql.org/33/, to make sure it won't be forgotten?

I was just looking at your patch, and I think that you should move all
the past compatibility tests into a separate test file, in a way
consistent to what we do in contrib/pageinspect/ for
oldextversions.sql. I would suggest to use the same file names, while
on it.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2021-08-25 07:43:15 Re: Failure of subscription tests with topminnow
Previous Message Peter Smith 2021-08-25 07:15:00 Re: logical replication empty transactions