| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_veryfybackup can fail with a valid backup for TLI > 1 |
| Date: | 2021-08-23 06:46:37 |
| Message-ID: | YSNETcvQvYlnJKrA@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 20, 2021 at 04:47:15PM +0900, Kyotaro Horiguchi wrote:
> Yes, backup_label looks correct.
>
> backup_label (extract):
> START WAL LOCATION: 0/5000028 (file 000000020000000000000005)
> CHECKPOINT LOCATION: 0/5000060
> START TIMELINE: 2
Okay. I have worked on that today, did more manual tests, and applied
this fix down to 13. The cherry-pick from 14 to 13 only required a
s/$master/$primary/ in the test, which was straight-forward. Your
patch for 13 did that though:
- if (starttli != entry->tli)
+ if (!XLogRecPtrIsInvalid(entry->begin))
So it would have caused a failure with parent TLIs that have a correct
begin location, but we expect the opposite. The patch for 14/HEAD had
that right.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-08-23 06:53:34 | Re: Mark all GUC variable as PGDLLIMPORT |
| Previous Message | Kyotaro Horiguchi | 2021-08-23 06:27:25 | Re: Some leftovers of recent message cleanup? |