| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "a(dot)lubennikova(at)postgrespro(dot)ru" <a(dot)lubennikova(at)postgrespro(dot)ru>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "matsumura(dot)ryo(at)fujitsu(dot)com" <matsumura(dot)ryo(at)fujitsu(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive status ".ready" files may be created too early |
| Date: | 2021-09-01 01:55:19 |
| Message-ID: | YS7dhx7Tpj/VMpMw@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 31, 2021 at 08:52:05PM -0400, alvherre(at)alvh(dot)no-ip(dot)org wrote:
> Yeah, that's becoming my conclusion too -- undo that, and start from
> scratch using the other idea.
That's about 515e3d8, right? I have not looked in details at what you
have here, but this produces a compilation warning on Windows for me
with this part of the patch:
+RegisterSegmentBoundary(XLogSegNo seg, XLogRecPtr endpos)
+{
+ XLogSegNo segno PG_USED_FOR_ASSERTS_ONLY;
segno gets to be an unreferenced local variable.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-09-01 01:55:58 | Re: pgstat_send_connstats() introduces unnecessary timestamp and UDP overhead |
| Previous Message | Michael Paquier | 2021-09-01 01:52:17 | Re: Postgres Win32 build broken? |