Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hans Buschmann <buschmann(at)nidsa(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
Date: 2021-08-18 00:10:16
Message-ID: YRxP6KWGfFRTnxCm@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 18, 2021 at 12:34:45AM +0800, Julien Rouhaud wrote:
> On Tue, Aug 17, 2021 at 11:26 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> Uh, I don't see those commits, e.g.:
>>
>> $ git diff 0d70d30
>> fatal: ambiguous argument '0d70d30': unknown revision or path not in the working tree.
>> Use '--' to separate paths from revisions, like this:
>> 'git <command> [<revision>...] -- [<file>...]'
>>
>> $ git diff 5c33ba5
>> fatal: ambiguous argument '5c33ba5': unknown revision or path not in the working tree.
>> Use '--' to separate paths from revisions, like this:
>> 'git <command> [<revision>...] -- [<file>...]'
>>
>> $ git diff 92436a7
>> fatal: ambiguous argument '92436a7': unknown revision or path not in the working tree.
>> Use '--' to separate paths from revisions, like this:
>> 'git <command> [<revision>...] -- [<file>...]'
>
> Same here. I'm assuming that the real commits are the one mentioned
> in the patch, which are c3826f8, aef8948 and ccf4e27.

Oops, incorrect copy-paste from my side. Yes, the commits impacted
here are aef8948, ccf4e27 and c3826f8. The small-ish commit message
of the patch got thet right.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-08-18 00:14:14 Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
Previous Message Jacob Champion 2021-08-18 00:06:59 Re: Support for NSS as a libpq TLS backend