| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Meskes <meskes(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE |
| Date: | 2021-08-16 06:27:26 |
| Message-ID: | YRoFTuos2VneTFnX@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 14, 2021 at 11:08:44PM -0400, Tom Lane wrote:
> Please do something about that.
>
> (1) There should be no output to stderr in the tests. Why isn't this
> message being caught and redirected to the normal test output file?
These are generated during the compilation of the tests with the
pre-processor, so that's outside the test runs.
> (2) This message is both unintelligible and grammatically incorrect.
Yeah, debugging such tests would be more helpful if the name of the
DECLARE statement is included, at least. Those messages being
generated is not normal anyway, which is something coming from the
tests as a typo with the connection name of stmt_3.
Michael, what do you think about the attached?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| fix-ecpg-tests.patch | text/x-diff | 7.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wu Haotian | 2021-08-16 06:35:06 | Re: Add option --drop-cascade for pg_dump/restore |
| Previous Message | Peter Smith | 2021-08-16 06:00:24 | Re: Added schema level support for publication. |