Re: elog.c query_id support vs shutdown

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: elog.c query_id support vs shutdown
Date: 2021-08-19 08:05:01
Message-ID: YR4Qrb3J3wgHmg3H@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 19, 2021 at 03:29:40PM +0800, Julien Rouhaud wrote:
> On Thu, Aug 19, 2021 at 3:05 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > The thread of this open item is now idle for 10 days and there does
> > not seem to be a lot of progress. Bruce, this is assigned to you.
> > Are you planning to look at it?
>
> I'm really sorry for the lack of answer on my side, I had too many
> duties at work to thoroughly look at the implication of clearing
> MyBEEntry in the pgstat_beshutdown_hook :(
>
> With what I've seen so far I didn't find any evidence that it could
> lead to any new problem (it should actually make things slightly
> safer) and couldn't hit any issue with some testing. Opinion from
> someone more familiar with pgstats is of course welcome.

Okay. Would you like to write a patch then?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-08-19 08:10:55 Re: elog.c query_id support vs shutdown
Previous Message Kyotaro Horiguchi 2021-08-19 08:03:15 Some leftovers of recent message cleanup?