Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hans Buschmann <buschmann(at)nidsa(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode
Date: 2021-08-19 03:29:44
Message-ID: YR3QKNmP4EFxcRHc@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 18, 2021 at 09:14:14AM +0900, Michael Paquier wrote:
> Sure. aef8948 gets down because of the performance impact. ccf4e27
> was a cleanup following up aef8948, that loses its meaning. And
> c3826f8 cannot be let alone because of the reasons why aef8948 was
> introduced, as it has no safety net for out-of-bound handling in the
> result buffer allocated.

And done, with such a description in the commit log.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-08-19 04:23:43 Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
Previous Message Michael Paquier 2021-08-19 03:28:07 Re: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist