Re: perlcritic: prohibit map and grep in void conext

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: perlcritic: prohibit map and grep in void conext
Date: 2021-07-28 04:23:12
Message-ID: YQDbsHXv7bt4E6my@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 27, 2021 at 09:09:10PM +0200, Daniel Gustafsson wrote:
> On 27 Jul 2021, at 18:06, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> wrote:
>> Attached is a patch that increases severity of that and the
>> corresponding `grep` policy to 5 to enable it in our perlcritic policy,
>> and fixes the one use that had already snuck in.
>
> +1, the use of foreach also improves readability a fair bit IMO.

Sounds interesting to avoid. pgperlcritic does not complain here
after this patch.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-07-28 05:02:41 Re: alter table set TABLE ACCESS METHOD
Previous Message Pavel Stehule 2021-07-28 04:18:01 Re: proposal: possibility to read dumped table's name from file