Re: wrong relkind error messages

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wrong relkind error messages
Date: 2021-07-21 02:21:23
Message-ID: YPeEo99s6MaQucRl@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 20, 2021 at 05:08:53PM +0200, Peter Eisentraut wrote:
> While reviewing the logical decoding of sequences patch, I found a few more
> places that could be updated in the new style introduced by this thread.
> See attached patch.

Those changes look fine. I am spotting one instance in
init_sequence() that looks worth aligning with the others?

Did you consider changing RangeVarCallbackForAlterRelation() or
ExecGrant_Relation() when it came to this thread? Just noticing that,
while going through the code.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-07-21 02:23:20 Re: 回复: Why is XLOG_FPI_FOR_HINT always need backups?
Previous Message wangyukun@fujitsu.com 2021-07-21 02:15:14 add 'noError' to euc_tw_and_big5.c