Re: Git revision in tarballs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Git revision in tarballs
Date: 2021-07-15 12:07:22
Message-ID: YPAk+lMmn6Pwmejs@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 15, 2021 at 01:44:45PM +0200, Magnus Hagander wrote:
> But only for *creating* the tarballs, and not for using them. I'm not
> sure what the usecase would be to create a tarball from an environment
> that doesn't have git?

Which would likely mean somebody creating a release tarball in an
environment doing a build with what is already a release tarball.
Adding a dependency to git in this code path does not sound that bad
to me, FWIW.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-07-15 12:08:04 Re: Rename of triggers for partitioned tables
Previous Message vignesh C 2021-07-15 12:05:23 Re: Removing unneeded self joins