Re: CREATE SEQUENCE with RESTART option

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Cary Huang <cary(dot)huang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE SEQUENCE with RESTART option
Date: 2021-07-26 07:57:53
Message-ID: YP5rAdQV3fs1S1Mb@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 24, 2021 at 09:56:40PM +0530, Bharath Rupireddy wrote:
> LGTM. PSA v2 patch.

FWIW, like Ashutosh upthread, my vote would be to do nothing here in
terms of behavior changes as this is just breaking a behavior for the
sake of breaking it, so there are chances that this is going to piss
some users that relied accidentally on the existing behavior.

I think that we should document that RESTART is accepted within the
set of options as a consequence of the set of options supported by
gram.y, though.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2021-07-26 08:13:27 Re: Some code cleanup for pgbench and pg_verifybackup
Previous Message Bharath Rupireddy 2021-07-26 07:33:18 Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation