Re: Introduce pg_receivewal gzip compression tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: gkokolatos(at)pm(dot)me
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Introduce pg_receivewal gzip compression tests
Date: 2021-07-12 11:04:34
Message-ID: YOwhwqCi+ii1dzF1@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 12, 2021 at 09:42:32AM +0000, gkokolatos(at)pm(dot)me wrote:
> This to my understanding means that gzip is expected to exist.
> If this is correct, then simply checking for the headers should
> suffice, since that is the only dependency for the files to be
> created.

You cannot expect this to work on Windows when it comes to MSVC for
example, as gzip may not be in the environment PATH so the test would
fail hard. Let's just rely on $ENV{GZIP} instead, and skip the test
if it is not defined.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Egor Rogov 2021-07-12 11:10:53 Re: pg_stats and range statistics
Previous Message Gilles Darold 2021-07-12 11:00:53 Re: Introduce pg_receivewal gzip compression tests