Re: ECPG doesn't compile CREATE AS EXECUTE properly.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: ECPG doesn't compile CREATE AS EXECUTE properly.
Date: 2021-07-06 02:17:47
Message-ID: YOO9SwZLM3bXDzGN@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 01, 2021 at 06:45:25PM +0900, Kyotaro Horiguchi wrote:
> Separating "CREATE TABLE AS EXECUTE" from ExecuteStmt would be cleaner
> but I avoided to change the syntax tree. Instead the attched make
> distinction of $$.type of ExecuteStmt between NULL and "" to use to
> notify the returned name is name of a prepared statement or a full
> statement.

I am not so sure, and using an empty string makes the code a bit
harder to follow. How would that look with the grammar split you have
in mind? Maybe that makes the code more consistent with the PREPARE
block a couple of lines above?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-07-06 02:48:47 Re: Re: parallel distinct union and aggregate support patch
Previous Message Amit Langote 2021-07-06 01:48:38 Re: simplifying foreign key/RI checks