| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Preventing abort() and exit() calls in libpq |
| Date: | 2021-06-28 07:52:12 |
| Message-ID: | YNl/rGAtp0Ovmtis@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jun 26, 2021 at 05:29:29PM -0400, Tom Lane wrote:
> I'll stick this into the CF list to see if the cfbot agrees that
> it finds the abort() problems...
The CF Bot is finding those problems.
> +# Check for functions that libpq must not call.
> +# (If nm doesn't exist or doesn't work on shlibs, this test will silently
> +# do nothing, which is fine.)
> +.PHONY: check-libpq-refs
> +check-libpq-refs: $(shlib)
> + @! nm -A -g -u $< 2>/dev/null | grep -e abort -e exit
"abort" and "exit" could be generic terms present in some other
libraries. Could be be better to match with "U abort" and "U exit"
instead? MinGW has a nm command, and it has a compatible option set,
so I think that it should work.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-06-28 07:53:28 | Re: Different compression methods for FPI |
| Previous Message | Michael Paquier | 2021-06-28 07:36:42 | Re: Different compression methods for FPI |