| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-committers(at)lists(dot)postgresql(dot)org, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Date: | 2021-06-27 01:22:24 |
| Message-ID: | YNfS0FB8XFbKlsbt@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Jun 26, 2021 at 11:01:07AM -0400, Andrew Dunstan wrote:
> On 6/26/21 2:47 AM, Fabien COELHO wrote:
>> However, if slurp_file fails it raises an exception and aborts the
>> whole TAP unexpectedly, which is pretty unclean. So I'd suggest to
>> keep the eval, as attached. I tested it by changing the file name so
>> that the slurp fails.
>
> Seem quite unnecessary. We haven't found that to be an issue elsewhere
> in the code where slurp_file is used. And in the present case we know
> the file exists because we got its name from list_files().
Agreed. That's an exchange between a hard failure mid-test and a
failure while letting the whole test run. Here, we expect the test to
find the log file all the time, so a hard failure does not sound like
a bad thing to me either.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2021-06-27 05:48:25 | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Previous Message | Tom Lane | 2021-06-26 19:45:25 | pgsql: Doc: update v14 release notes for revert of commit c0cb87fbb. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-06-27 01:30:23 | Re: Pipeline mode and PQpipelineSync() |
| Previous Message | Alexander Korotkov | 2021-06-26 23:35:48 | Re: unnesting multirange data types |