Re: [PATCH] Pull general SASL framework out of SCRAM

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
Date: 2021-06-26 00:47:02
Message-ID: YNZ5Bqq4GvhNvbp0@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 25, 2021 at 11:40:33PM +0000, Jacob Champion wrote:
> I can definitely move it (into, say, auth-sasl.c?). I'll probably do
> that in a second commit, though, since keeping it in place during the
> refactor makes the review easier IMO.

auth-sasl.c is a name consistent with the existing practice.

> Can do. Does libpq-int-sasl.h work as a filename? This should not be
> exported to applications.

I would still with the existing naming used by fe-gssapi-common.h, so
that would be fe-auth-sasl.c and fe-auth-sasl.h, with the header
remaining internal. Not strongly wedded to this name, of course, that
just seems consistent.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-06-26 03:50:24 Re: Some incorrect logs in TAP tests of pgbench
Previous Message Michael Paquier 2021-06-26 00:37:47 Re: [patch] remove strver's leftover from error message in Solution.pm