| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Some incorrect logs in TAP tests of pgbench |
| Date: | 2021-06-25 12:33:25 |
| Message-ID: | YNXNFaG7IgkzZanD@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
While digging into some of the TAP tests, I have noticed that
002_pgbench_no_server.pl prints array pointers, like that:
opts=-f no-such-file, stat=1, out=ARRAY(0x1374d7990),
err=ARRAY(0x14028dc40), name=pgbench option error: no file# Running:
pgbench -f no-such-file
I am a bit dubious that this information is useful when it comes to
debugging because we have the name of the tests close by, so I would
just remove those extra logs. If people prefer keeping this
information around, we could fix the format with something like the
attached, for example.
Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-tap-logs.patch | text/x-diff | 694 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-06-25 12:53:37 | Re: alter subscription drop publication fixes |
| Previous Message | Michael Paquier | 2021-06-25 12:24:23 | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |