Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Date: 2021-06-25 00:26:21
Message-ID: YNUirR5z+0xYjiu9@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

(Forgot to add Andrew in CC, now done)

On Fri, Jun 25, 2021 at 08:51:19AM +0900, Michael Paquier wrote:
> Andrew, what's the format of the per-thread logs generated on this
> host when running the commands? I'd bet that the checks for the
> client IDs are right, but that some parts of the regex are too picky
> when it comes to this host.

I have tested that on my own Windows host using MSVC and Active Perl,
and those tests pass. I am not sure what's happening here. A simple
way to figure out what's going on would be to make the tests more
talkative and show up the logs that don't match.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-06-25 00:57:19 pgsql: Add more debugging information with log checks in TAP tests of p
Previous Message Michael Paquier 2021-06-24 23:51:19 Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiro Ikeda 2021-06-25 00:53:52 Re: Transactions involving multiple postgres foreign servers, take 2
Previous Message Michael Paquier 2021-06-24 23:51:19 Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench