Re: Dependency to logging in jsonapi.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Dependency to logging in jsonapi.c
Date: 2021-07-02 01:31:11
Message-ID: YN5sX7GBuy4yROai@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 30, 2021 at 07:00:31PM -0400, Tom Lane wrote:
> If this code were new in v14, I'd be +1, but it looks like it was
> there in 13 too. So maybe there's somebody external depending on
> it, which would make it a bit unfriendly to remove it post-beta.
> Let's just add the #ifndef in HEAD.

Right, I needed more caffeine at this point in time. I have cleaned
up that on HEAD, adding an assert at the end of report_parse_error()
as you suggested.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-07-02 01:37:45 Re: Commit fest manager
Previous Message Bruce Momjian 2021-07-02 01:29:01 Re: Commit fest manager