Re: Different compression methods for FPI

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Different compression methods for FPI
Date: 2021-06-17 07:01:35
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jun 17, 2021 at 03:44:26PM +0900, Michael Paquier wrote:
> I have worked more on that today and finished with two patches:
> - 0001 is the mininal patch to add support for LZ4. This is in a
> rather committable shape. I noticed that we checked for an incorrect
> error code in the compression and decompression paths as LZ4 APIs can
> return a negative result. There were also some extra bugs I spotted.
> Its size is satisfying for what it does, and there is MSVC support
> out-of-the-box:
> 12 files changed, 176 insertions(+), 48 deletions(-)
> - 0002 is the extra code need to add ZSTD and do the same. This still
> requires support for MSVC and I have not checked the internals of ZSTD
> to see if we do the compress/decompress calls the right way.
> While on it, I am going to switch my buildfarm animal to use LZ4 for
> toast.. Just saying.

And I forgot to attach these. (Thanks Andrey!)

Attachment Content-Type Size
v11-0001-Add-wal_compression-lz4.patch text/x-diff 18.6 KB
v11-0002-Add-wal_compression-zstd.patch text/x-diff 20.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-06-17 07:08:05 Re: Python 3.10 breaks regression tests with traceback changes
Previous Message Fabien COELHO 2021-06-17 07:00:50 Re: pgbench logging broken by time logic changes