From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: SSL Tests for sslinfo extension |
Date: | 2021-06-17 07:29:07 |
Message-ID: | YMr5w68Yxf5lF69u@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 20, 2021 at 08:40:48PM +0200, Daniel Gustafsson wrote:
> > On 19 May 2021, at 21:05, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >
> > On 5/19/21 1:01 PM, Dagfinn Ilmari Mannsåker wrote:
> >> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> >>
> >>> In order to be able to test extensions with SSL connections, allow
> >>> configure_test_server_for_ssl to create any extensions passed as
> >>> comma separated list. Each extension is created in all the test
> >>> databases which may or may not be useful.
> >> Why the comma-separated string, rather than an array reference,
> >> i.e. `extensions => [qw(foo bar baz)]`?
>
> No real reason, I just haven't written Perl enough lately to "think in Perl".
> Fixed in the attached.
Hmm. Adding internal dependencies between the tests should be avoided
if we can. What would it take to move those TAP tests to
contrib/sslinfo instead? This is while keeping in mind that there was
a patch aimed at refactoring the SSL test suite for NSS.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2021-06-17 07:34:05 | Re: pgbench logging broken by time logic changes |
Previous Message | Amit Langote | 2021-06-17 07:27:56 | Re: Skip partition tuple routing with constant partition key |