Re: Added missing tab completion for alter subscription set option

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Added missing tab completion for alter subscription set option
Date: 2021-06-11 06:56:56
Message-ID: YMMJOI43ehcvBO42@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote:
> /* Complete "CREATE SUBSCRIPTION <name> ... WITH ( <opt>" */
> else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH", "("))
> - COMPLETE_WITH("copy_data", "connect", "create_slot", "enabled",
> - "slot_name", "synchronous_commit");
> + COMPLETE_WITH("binary", "copy_data", "connect", "create_slot",
> + "enabled", "slot_name", "streaming",
> + "synchronous_commit");

"copy_data" and "connect" need to be reversed. Applied.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-06-11 07:02:04 Re: Error on pgbench logs
Previous Message Kyotaro Horiguchi 2021-06-11 06:56:55 Re: Error on pgbench logs