| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Paul Guo <guopa(at)vmware(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Two patches to speed up pg_rewind. |
| Date: | 2021-06-02 05:20:10 |
| Message-ID: | YLcVCgnXTKidYfvG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 28, 2021 at 05:30:51AM +0000, Paul Guo wrote:
> Did some small modification and rebased the code. See attached for the new version.
Regarding patch 0002, I find the inter-dependencies between
write_target_range() and copy_target_range() a bit confusing. There
is also a bit of duplication for dry_run, fetch_done and the progress
reporting. Perhaps it would be cleaner to have a fallback
implementation of copy_file_range() in src/port/ and reduce the
footprint of the patch in pg_rewind?
Note: FreeBSD 13~ has support for copy_file_range(), nice.. Adding
Thomas in CC in case I am missing something.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-06-02 05:23:22 | Re: Alias collision in `refresh materialized view concurrently` |
| Previous Message | Michael Paquier | 2021-06-02 05:05:44 | Re: Speed up pg_checksums in cases where checksum already set |