| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | TAP tests still sensitive to various PG* environment variables |
| Date: | 2021-06-02 01:49:01 |
| Message-ID: | YLbjjRpucIeZ78VQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
While looking at a separate issue, I have noticed that TestLib.pm is
lagging behind in terms of environment variables it had better mask to
avoid failures:
https://www.postgresql.org/message-id/YLXjFOV3teAPirmS@paquier.xyz
Once I began playing with the variables not covered yet, and tested
fancy cases with junk values, I have been able to see various failures
in the TAP tests, mainly with authentication and SSL.
Attached is a patch to strengthen all that, which I think we'd better
backpatch.
Any objections to that?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| testlib-envs.patch | text/x-diff | 1006 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-06-02 01:56:42 | Re: return correct error code from pgtls_init |
| Previous Message | houzj.fnst@fujitsu.com | 2021-06-02 01:37:51 | Fixup some appendStringInfo and appendPQExpBuffer calls |