From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Zhang <zhubert(at)vmware(dot)com>, tsunakawa(dot)takay(at)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: Multiple hosts in connection string failed to failover in non-hot standby mode |
Date: | 2021-06-08 03:24:31 |
Message-ID: | YL7i73c8vDGD+Gjy@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jun 07, 2021 at 10:38:03AM -0400, Tom Lane wrote:
> Hmm. We do include "-lpgcommon -lpgport" when building the ecpg test
> programs on Unix, so I'd assumed that the MSVC scripts did the same.
> Is there a good reason not to make them do so?
I was looking at that this morning, and yes we need to add more
references here. Actually, adding only libpgport.lib allows the
compilation and the tests to work, but I agree to add also
libpgcommon.lib so as we don't fall into the same compilation trap
again in the future.
Now, I also see that using pgwin32_setenv() instead of
src/port/setenv.c causes cl to be confused once we update
ecpg_regression.proj because it cannot find setenv(). Bringing the
question, why is it necessary to have both setenv.c and
pgwin32_setenv() on HEAD? setenv.c should be enough once you have the
fallback implementation of putenv() available.
Attached is the patch I am finishing with, that also brings all this
stuff closer to what I did in 12 and 13 for hamerkop. The failing
test is passing for me now with MSVC and GSSAPI builds.
Thoughts?
--
Michael
Attachment | Content-Type | Size |
---|---|---|
disable-GSS-in-ECPG-test-v2.patch | text/x-diff | 13.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-06-08 03:33:45 | Re: [bug?] Missed parallel safety checks, and wrong parallel safety |
Previous Message | YoungHwan Joo | 2021-06-08 03:09:47 | Error on pgbench logs |