Re: Small issues with CREATE TABLE COMPRESSION

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <pchampion(at)vmware(dot)com>
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Date: 2021-05-11 01:48:54
Message-ID: YJnihpTBiDty49sB@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 10, 2021 at 12:17:19PM +0530, Dilip Kumar wrote:
> Even I was confused about that's the reason I used liblz4_static.lib,
> but I see you have changed to liblz4.lib to make it consistent I
> guess?

That's the name the upstream code is using, yes.

> Patch looks good to me, I can not verify though because I don't have
> such an environment. Thanks for improving the patch.

Thanks, I got that applied to finish the work of this thread for
beta1. At least this will give people an option to test LZ4 on
Windows. Perhaps this will require some adjustments, but let's see if
that's necessary when that comes up.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-05-11 01:56:45 Re: PG 14 release notes, first draft
Previous Message Andres Freund 2021-05-11 01:27:55 Re: Is element access after HASH_REMOVE ever OK?