| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, David Pirotte <dpirotte(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br> |
| Subject: | Re: subscriptioncheck failure |
| Date: | 2021-05-14 05:30:14 |
| Message-ID: | YJ4K5uZi9pc8pivV@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 13, 2021 at 07:05:55PM +0530, vignesh C wrote:
> Thanks for the comments, Please find the attached patch having the changes.
Cool, thanks for the new version. I have spent some time
understanding the initial report from Amit as well as what you are
proposing here, and refactoring the test so as the set of CREATE/ALTER
SUBSCRIPTION commands are added within this routine is a good idea.
I would have made the comment on top of setup_subscription a bit more
talkative regarding the fact that it may reuse an existing
subscription, but that's a nit. Let's wait for Amit and see what he
thinks about what you are proposing.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-05-14 05:37:02 | Re: Support for VACUUMing Foreign Tables |
| Previous Message | Dilip Kumar | 2021-05-14 05:27:34 | Re: OOM in spgist insert |