| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Joel Jacobson <joel(at)compiler(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids |
| Date: | 2021-04-26 08:30:25 |
| Message-ID: | YIZ6IRF7o0y6AVni@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 23, 2021 at 09:33:36AM +0200, Joel Jacobson wrote:
> Also, since this is a problem also in v13 maybe this should also be
> back-ported? I think it's a bug since both
> pg_identify_object_as_address() and event triggers exists in v13, so
> the function should work there as well, otherwise users would need
> to do work-arounds for event triggers.
No objections from here to do something in back-branches. We cannot
have a test for event triggers in object_address.sql and it would be
better to keep it in a parallel set (see 676858b for example). Could
you however add a small test for that in event_trigger.sql? It would
be good to check after all three functions pg_identify_object(),
pg_identify_object_as_address() and pg_get_object_address().
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yuya Watari | 2021-04-26 08:32:17 | Re: Performance Evaluation of Result Cache by using TPC-DS |
| Previous Message | Amit Kapila | 2021-04-26 08:12:32 | Re: [PATCH] add concurrent_abort callback for output plugin |