Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows
Date: 2021-04-17 13:04:27
Message-ID: YHrc24AgJQ6tQ1q0@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 15, 2021 at 09:12:52PM -0400, Andrew Dunstan wrote:
> It's worked on fairywren, I will double check on drongo and if all is
> well will commit.

Thanks Andrew. For the archive's sake, this has been committed as of
3c5b068.

While reading the commit, I have noticed that you used SEEK_SET
instead of 0 as I did in my own patch. That makes the code easier to
understand. Could it be better to apply the same style to all the
perl scripts doing some seek() calls? Please see the attached.
--
Michael

Attachment Content-Type Size
tap-seek.patch text/x-diff 4.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-04-17 13:32:00 Re: Table refer leak in logical replication
Previous Message Esteban Zimanyi 2021-04-17 11:12:24 Re: Error when defining a set returning function